chore(OC_App): migrate more legacy function and usage#60071
Merged
Conversation
susnux
added
3. to review
susnux
force-pushed
the
chore/legacy
branch
3 times, most recently
from
031c44c to
8c22c09
Compare
susnux
requested review from
leftybournes,
nfebe,
salmart-dev and
sorbaugh
and removed request for
a team
artonge
reviewed
May 6, 2026
artonge
approved these changes
May 6, 2026
provokateurin
previously requested changes
May 7, 2026
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
LGTM, just a few small things that could be improved.
| * This function walks through the Nextcloud directory and loads all apps | ||
| * it can find. A directory contains an app if the file `/appinfo/info.xml` | ||
| * exists. | ||
| * | ||
| * if $types is set to non-empty array, only apps of those types will be loaded | ||
| * @param string[] $types - If set, only apps of these types will be loaded |
Member
There was a problem hiding this comment.
Suggested change
| * @param string[] $types - If set, only apps of these types will be loaded | |
| * @param list<string> $types - If set, only apps of these types will be loaded |
Contributor
Author
There was a problem hiding this comment.
This would be a "breaking change" because then the function requires more specific parameter.
I think functions should take arrays as param but return list, so they allow more flexible usage while return type is specific to ease using it.
Especially here its valid to pass an array, we handle it properly
come-nc
reviewed
May 7, 2026
susnux
commented
May 13, 2026
…o AppManager Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
icewind1991
approved these changes
May 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move more functions to AppManager that still make sense to be shared.
Moreover usage is migrated to AppManager instead of legacy
OC_App.Checklist
3. to review, feature component)stable32)AI (if applicable)